Change to working timestamp server URL#13
Open
alexd-shuttle wants to merge 1 commit intokevinsawicki:masterfrom
Open
Change to working timestamp server URL#13alexd-shuttle wants to merge 1 commit intokevinsawicki:masterfrom
alexd-shuttle wants to merge 1 commit intokevinsawicki:masterfrom
Conversation
|
When will this be released? |
Author
|
I have no control over releasing this, I'm just a random contributor. @kevinsawicki if you want to release this change, this would solve the problem that currently signcode isn't working because it's linking to an old URL |
kitsune7
approved these changes
Jul 29, 2021
kitsune7
left a comment
kitsune7
left a comment
There was a problem hiding this comment.
I just tested this and it fixed the issue for me. @kevinsawicki, would you be able to approve and merge this PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The verisign timestamp server is no more. Details:
https://stackoverflow.com/a/65541787/1298835
The simplest solution is to change verisign → digicert. ( #12 )
An even better solution would be making it configurable. ( #11 )
Fixes #7
Fixes #12
You can use the PR in your project to make signcode usable again:
yarn:
yarn add kevinsawicki/signcode#13/headnpm:
npm install kevinsawicki/signcode#pull/13/head